search

Nightmare-n / UniPAD

UniPAD: A Universal Pre-training Paradigm for Autonomous Driving (CVPR 2024)
https://arxiv.org/abs/2310.08370
Apache License 2.0
167 stars 7 forks source link

Bug of the SSL testing #13

Closed tangtaogo closed 2 months ago

tangtaogo commented 6 months ago

Hello, Thank you for your excellent work! There is a bug in the test of UVTRSSL: https://github.com/Nightmare-n/UniPAD/blob/2de0c0544f2951fa67bcba2e8dec9f7fc6a80a39/projects/mmdet3d_plugin/models/detectors/uvtr_ssl.py#L257 The passed parameters do not match the definition: https://github.com/Nightmare-n/UniPAD/blob/2de0c0544f2951fa67bcba2e8dec9f7fc6a80a39/projects/mmdet3d_plugin/models/dense_heads/render_head.py#L84 It seems that the forward_test function in render_head was forgotten to be committed. Looking forward to your response.

tangtaogo commented 6 months ago

Also in the test of UVTRSSL: https://github.com/Nightmare-n/UniPAD/blob/2de0c0544f2951fa67bcba2e8dec9f7fc6a80a39/projects/mmdet3d_plugin/models/detectors/uvtr_ssl.py#L264 the vis_weights is not define

DingYikang commented 2 months ago

Hi, same question. Is there any update?

Nightmare-n commented 2 months ago

I have updated the code (not strictly tested). Please try again.

tangtaogo commented 2 months ago

Thanks !!!!