NightmareXIV / DynamicBridge

13 stars 5 forks source link

Gear appearance not reverting when rules don't apply a gear preset #6

Closed PrincessRTFM closed 7 months ago

PrincessRTFM commented 7 months ago

I have several (layered) presets for gear that include my customisations for colours outside the game's own set, and one customisation-only preset used as a default just for the colours. I have a set of rules for the application of the layered presets, ending with the application of only the Glamourer customisation-only preset; my formatted profile JSON can be found below.

When I'm on a job that doesn't have a gear preset applied, but I am in a location that does (eg, ninja in my apartment) and I teleport to a location that doesn't have a gear preset, the rules (correctly) apply my "fallback" customisation-only preset but my gear appearance is not reverted and "sticks" on the previous override.

My settings are configured to revert to Glamourer's automation (which has nothing configured for my character), and to not override Glamourer's automation setting, as this breaks auto-designs for NPCs. Since I have removed all Glamourer automation for non-NPCs, this isn't expected to cause any issues with conflicts between the two.

Dynamic Bridge profile export ```js { "Name": "Vix Redblade@Cactuar", "Rules": [ { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [ 22237979280801920 ], "Emotes": [], "Jobs": [], "Times": [], "SelectedPresets": [ "Comfy topless" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [ 2, 1, 0, 3 ], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [ 45, 143, 88, 100, 99 ], "Jobs": [], "Times": [], "SelectedPresets": [ "Comfy topless" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [ 1, 2, 3, 0 ], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [], "SelectedPresets": [ "Comfy at home" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [ 35 ], "Times": [], "SelectedPresets": [ "Blazing red" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [ 6, 7, 8, 9, 5 ], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [ 38 ], "Times": [], "SelectedPresets": [ "Beach dancer" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [ 38 ], "Times": [], "SelectedPresets": [ "Faire dancer" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [ 31 ], "Times": [], "SelectedPresets": [ "Steampunk sniper" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [ 39 ], "Times": [], "SelectedPresets": [ "Teenage reaper" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } }, { "Enabled": true, "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [], "SelectedPresets": [ "Baseline" ], "Passthrough": false, "Not": { "States": [], "SpecialTerritories": [], "Biomes": [], "Territories": [], "Weathers": [], "Houses": [], "Emotes": [], "Jobs": [], "Times": [] } } ], "Presets": [ { "Name": "Baseline", "Glamourer": [ "5e54bc6d-e12f-4115-9397-65e76c5a645b" ], "ComplexGlamourer": [], "Honorific": [], "Palette": [], "Customize": [], "IsStatic": false } ], "PresetsFolders": [ { "Name": "SFW", "Presets": [ { "Name": "Blazing red", "Glamourer": [], "ComplexGlamourer": [ "[S] Blazing red" ], "Honorific": [], "Palette": [], "Customize": [ "Big chest - Vix Redblade" ], "IsStatic": false }, { "Name": "Beach dancer", "Glamourer": [], "ComplexGlamourer": [ "[S] Beach dancer" ], "Honorific": [], "Palette": [], "Customize": [ "Big chest - Vix Redblade" ], "IsStatic": false }, { "Name": "Faire dancer", "Glamourer": [], "ComplexGlamourer": [ "[S] Faire dancer" ], "Honorific": [], "Palette": [], "Customize": [ "Big chest - Vix Redblade" ], "IsStatic": false }, { "Name": "Blind didact", "Glamourer": [], "ComplexGlamourer": [ "[S] Blind didact" ], "Honorific": [], "Palette": [], "Customize": [], "IsStatic": false }, { "Name": "Steampunk sniper", "Glamourer": [], "ComplexGlamourer": [ "[S] Steampunk sniper" ], "Honorific": [], "Palette": [], "Customize": [ "Big chest - Vix Redblade" ], "IsStatic": false }, { "Name": "Teenage reaper", "Glamourer": [], "ComplexGlamourer": [ "[S] Teenage reaper" ], "Honorific": [], "Palette": [], "Customize": [], "IsStatic": false }, { "Name": "Comfy at home", "Glamourer": [], "ComplexGlamourer": [ "[S] Comfy at home" ], "Honorific": [], "Palette": [], "Customize": [ "Big chest - Vix Redblade" ], "IsStatic": false } ], "HiddenFromSelection": false }, { "Name": "NSFW", "Presets": [ { "Name": "Beach bulge", "Glamourer": [], "ComplexGlamourer": [ "[N] Beach bulge" ], "Honorific": [], "Palette": [], "Customize": [], "IsStatic": false }, { "Name": "Comfy topless", "Glamourer": [], "ComplexGlamourer": [ "[N] Sleepy topless" ], "Honorific": [], "Palette": [], "Customize": [], "IsStatic": false } ], "HiddenFromSelection": false } ], "ForcedPreset": null, "IsGlobal": false } ```
Limiana commented 7 months ago

Hello! Just as with Glamourer itself, reverting to automation isn't available unless you actually have it enabled and configured in Glamourer for this character so it makes sense that there's nothing to revert to. Could you please use revert to game state options? I'll include warnings about that in future.

PrincessRTFM commented 7 months ago

Just to be sure I have this right, my settings should be "revert to game state" and "do not allow DB to manage Glamourer's automation setting", correct?

PrincessRTFM commented 7 months ago

Update: using those settings, the problem persists. I suspect it's because a preset is being applied, which prevents reverting my appearance entirely, but the preset in question doesn't apply any overrides to my gear, only to my character customisations.

Limiana commented 7 months ago

Update: using those settings, the problem persists. I suspect it's because a preset is being applied, which prevents reverting my appearance entirely, but the preset in question doesn't apply any overrides to my gear, only to my character customisations.

okay, I think I understand now, you have new rule overlaying appearance over old rule's appearance, right? So essentially what you need is revent character appearance before applying new rule option I believe. Last time it was in the plugin it did not worked with Glamourer. Might need to wait for new Glamourer update to be out of testing before I'll be able to add that function back.

PrincessRTFM commented 7 months ago

I think that would do it, yes. Layering applied rules on either the base game appearance or Glamourer automation state would make the final appearance consistent in cases like this, where the new rules being applied don't affect every value that the previous rules did.

Limiana commented 7 months ago

@PrincessRTFM I've added "revert before applying" option into plugin's settings, please test it

PrincessRTFM commented 7 months ago

That worked perfectly!