search

NightmareXIV / ECommons

A library for Dalamud
MIT License
34 stars 40 forks source link

Action effect change. #12

Closed ArchiDog1998 closed 1 year ago

ArchiDog1998 commented 1 year ago

Add more data, and make the hook as events.

Notice: I found that this field is never set. https://github.com/NightmareXIV/ECommons/blob/c21224507810fa49ebd746665144ca79c357fad8/ECommons/Hooks/ActionEffect.cs#L22

Limiana commented 1 year ago

The field is likely from Damage info plugin, from where majority of this code was actually copied. Thanks for additions, I wasn't using event because I had concerns that it may add performance overhead but I could confirm it actually does not add any delay

Limiana commented 1 year ago

@ArchiDog1998 hey, I want to thank you again for this PR, it proven to be extremely useful