NightmareXIV / JustBackup

GNU Affero General Public License v3.0
15 stars 8 forks source link

Too many backup folders being written by plugin #11

Open Shiichibukai opened 1 year ago

Shiichibukai commented 1 year ago

As title says, noticed JustBackup is creating far too many backup folders in the %localappdata%/Temp folder as seen in the picture - aside from 2-3 from the top every folder has a size of about 1.5 to 2GB of Disk Space. I dont think this should be the intended behaviour.

image

Shiichibukai commented 1 year ago

Screenshot 2023-02-11 182642

Limiana commented 1 year ago

Hello. Have you been crashing on startup a lot? Normally these folders should be gone once backup is done but in case your game crashed while backup wasn't finished yeah it will be like this I'll add some cleanup mechanism in next version

Shiichibukai commented 1 year ago

More on Close rather than Startup, but that was a Dalamud issue from what I read.

Thank you

Delaene commented 1 year ago

One thing i never noticed/gave attention to, does anything pop up when a backup is finished? Might aswell be this amount of folders is what's left of an incomplete backup because you closed the game before it finished. image

Limiana commented 1 year ago

@Delaene Once backup is finished, an in-game notification is displayed. At the same time cleanup is performed as well. So if backup takes a while and you closed the game before it finished, temporary files will indeed be kept