search

NightmareXIV / NotificationMaster

Notifies you about various events while your game is minimized.
GNU Affero General Public License v3.0
9 stars 3 forks source link

[Suggestion] Trigger plugin when someone join your party #8

Open Lukkies opened 2 years ago

Lukkies commented 2 years ago

Not unusual you opening a Party Finder and going afk while waiting ppl to join. Currently mitigating this problem by a trigger for party chat, but obviasly this just work when they say something in the chat (which is not always the case), so a trigger to prevent someone leaving the party thinking its dead would be very helpful.

Limiana commented 2 years ago

I'll get to adding party events as soon as I will have some spare time to do so

Limiana commented 2 years ago

don't close issue until it's done please, or I will lose track of it

enoch-ng commented 2 years ago

An option to send a notification specifically once the party fills would also be great as this is of course the most important event.

Tischel commented 6 months ago

Would you accept a PR with this feature? I haven't really started yet but I was thinking in probably doing it as a feature on this plugin instead of making something from scratch.

Limiana commented 6 months ago

Would you accept a PR with this feature? I haven't really started yet but I was thinking in probably doing it as a feature on this plugin instead of making something from scratch.

Hey, sure! It should be pretty straightforward. I hope to do a rework of the plugin before DT as well, the code is quite outdated there.

Tischel commented 6 months ago

I opened https://github.com/NightmareXIV/NotificationMaster/pull/17 that implements this feature. Let me know if you have any questions or concerns.