NightrainsRbx / RobloxLsp

Roblox Luau Language Server based on Lua by sumneko.
https://devforum.roblox.com/t/roblox-lsp-full-intellisense-for-roblox-and-luau/717745
MIT License
211 stars 49 forks source link

Shared table implementation #228

Closed VoidedBlades closed 10 months ago

VoidedBlades commented 1 year ago

Shared table global keyword support, vulnerability fixes and change from onReady to onDidChangeState as a result from onReady being removed on package update.

NightrainsRbx commented 1 year ago

This isn't the right way to define it, DataTypes would go in: https://github.com/NightrainsRbx/RobloxLsp/blob/master/server/api/DataTypes.json

The rest globals would go env.luau

Also, why is the change of onReady?

VoidedBlades commented 1 year ago

My bad, will adjust the data type in a second.

The onReady change was made after updating the packages (whom on install prior to that mentioned security vulnerabilities) where errors were presented during debugging that onReady was no longer present as a usable connection as stated in the commit message.

Due to that it was required to change over to onDidStateChange and check if the state changed to Running.

TheCoderCat418 commented 10 months ago

This would be very helpful, any plans to merge this?

NightrainsRbx commented 10 months ago

This would still be wrong since you are declaring the methods where the constructors are declared, I will close this because another PR for this has been merged.