search

NightscoutFoundation / xDrip

Nightscout version of xDrip+
https://jamorham.github.io/#xdrip-plus
GNU General Public License v3.0
1.4k stars 1.14k forks source link

Speak alarms on Android Auto #1423

Open tim162 opened 4 years ago

tim162 commented 4 years ago

It would be awesome to have compatibility with Android Auto as more and more cars are able to use it.

Example 1: User is driving the car and gets new high/low alarm notification, Android Auto could be able to read sth like "Your blood glucose is ..."

Example 2: No new notification but user wants to know his/her current bg so asks sth like "What's my current blood glucose?" and will get the answer.

I am starting to read into this topic and trying the implementation in a small basic app to see how it works. If anyone already has some experience with Android Auto, it would be great if you could have a look how it would be possible to implement.

gitanO0 commented 4 years ago

I second this.

playingbball20 commented 4 years ago

I would like the feature also. I have looking into adding it, but haven't had enough time to do it. I have been using CarNotifier. I'm not sure if it is in the app store or not, but you can download it https://rb.gy/us4ikd and install it. If you do not know how to sideload or have never heard of it, just download the link on your phone and once it downloads, open it and it will ask if you want to install it, select yes. When you make changes to CarNotifier, you have to make sure you exit the app, then open it back up, otherwise it won't work correctly.

Roxy-3D commented 4 years ago

My preference would be it takes over one of the standard buttons that I don't use on the console. Like 'Radio' (I only use the Media player button). And when pressed, have it show the normal phone xDrip screen.

techn0c commented 4 years ago

Here, here! Cool idea.

tim162 commented 4 years ago

I have successfully tested a first version of the feature with xDrip+ in my car. It supports a spoken message eg "Your bloodsugar is at 180 and changed +2.5 since your last reading" when a new alarm is coming in.

My question now is what is the best way to "officially" contribute features like that? It is my first time to contribute to xDrip so i would be very happy for some help, maybe @jamorham ?

tzachi-dar commented 4 years ago

Best thing is to open a PR against the newest xDrip version with your code.

On Fri, 2 Oct 2020 at 21:27, Tim Ulbrich notifications@github.com wrote:

I have successfully tested a first version of the feature with xDrip+ in my car. It supports a spoken message eg "Your bloodsugar is at 180 and changed +2.5 since your last reading" when a new alarm is coming in.

My question now is what is the best way to "officially" contribute features like that? It is my first way to contribute to xDrip so i would be very happy for some help, maybe @jamorham https://github.com/jamorham ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/1423#issuecomment-702889884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4TBZA4DFV24V5A24TYMKLSIYLQLANCNFSM4QNLJWQQ .

tim162 commented 3 years ago

@tzachi-dar and everyone interested: I opened a PR https://github.com/NightscoutFoundation/xDrip/pull/1533#issue-530453200

I implemented the feature in a different way (imo better), explained everything in the PR comment.

tolot27 commented 3 years ago

Looks like it duplicates #1071.

Navid200 commented 3 years ago

We already have an open request here for Android Auto: https://github.com/NightscoutFoundation/xDrip/issues/520

Can we close this issue in favor of the older one?

tolot27 commented 3 years ago

We already have an open request here for Android Auto: #520

Can we close this issue in favor of the older one?

The two requests are similar but not identical. #520 requests to display notifications while this issue requests to enhance the spoken alarms to Android Auto. For this request, a PR #1533 already exists. Hence, I recommend not to close this issue unless the PR gets merged or rejected.

Navid200 commented 3 years ago

@tolot27 I have no experience with xDrip and Android Auto.

If xDrip works with Android Auto, I would love to know because there have been times I would have liked to use it. If xDrip works with Android Auto, we should close: https://github.com/NightscoutFoundation/xDrip/issues/520

If xDrip doesn't work with Android Auto, I don't believe it makes sense to have a second open issue for adding something more to xDrip after it is modified to be operational with Android Auto. In that case, requests for additional capabilities can either wait or added to the existing open issue.

Of course, I may be misunderstanding. So, would you please clarify what's going on for me please?