revise source text strings and their translations

NightscoutFoundation / xDrip

Nightscout version of xDrip+

https://jamorham.github.io/#xdrip-plus

GNU General Public License v3.0

1.39k stars 1.14k forks source link

revise source text strings and their translations #1554

Open tolot27 opened 3 years ago

tolot27 commented 3 years ago

Some English source text strings contain unusual characters (spaces, quotation marks, smileys, etc.) and should be corrected. Their translations should also checked.

[ ] remove smileys (sample: settingdisabled)
[ ] remove bracket artifacts
[ ] remove unnecessary spaces, especially in URLs
[ ] revert variable name translations (written within curly brackets `{})
[ ] try to correct anglicism like denglish
[ ] disable translations of strings which never appear in the GUI (i. e. title_activity_nav_drawer, navigation_drawer_open and navigation_drawer_close)
[ ] disable translations of numbers (i. e. zero_zero_zero_zero)

tolot27 commented 3 years ago

@jamorham IMHO, we should enable 'Push Sources' at crowdins GitHub integration as well because sometimes, the original English text has to be corrected. In theory, this could produce merge conflicts if the same string is changed by an xDrip PR which is rarely the case. But if we do not enable it, we will lost the changes made at crowdin or getting out of sync with github, as it happened recently (#1559).

jamorham commented 3 years ago

Could you give me an example of the last 4 items so I understand what these mean and what is planned to be changed. Some items might be as they are for a reason.

tolot27 commented 3 years ago

@jamorham The linked PR contains many of the fixes. Some of the problems listed above were fixed previously. I cannot remember on the anglicism, anymore.

tolot27 commented 3 years ago

Some of the tasks are still not fixed. I'll check this soon.