search

NightscoutFoundation / xDrip

Nightscout version of xDrip+
https://jamorham.github.io/#xdrip-plus
GNU General Public License v3.0
1.42k stars 1.15k forks source link

Sending activity level and heart beat rate to nightscout #1857

Closed pooyaww closed 6 months ago

pooyaww commented 3 years ago

In xDrip it is possible to collect these data, it would be nice if we could have them on Nightsout also. Activity level, in particular for children, is an important factor for low predictions. Besides, heart beat level is also important to decide on the current state of activities.

Navid200 commented 3 years ago

@tolot27 I see this closely related to the following. https://github.com/NightscoutFoundation/xDrip/issues/1476 Of course, this one wants to upload to Nightscout and other wants to upload to tidepool. Someone may want to open another one for uploading the same to another server.
But, what is common between all of these is what is requested from xDrip to upload.

If the person who has to approve uploading such data doesn't feel that the data should be uploaded (I'm not saying that's the case), he/she is not going to approve any of them. Is there really a benefit in having more requests? In my opinion, we should combine related requests. If some day a developer creates a PR for only uploading to Nightscout but not to tidepool, the combined issue will remain open because it hasn't been addressed fully.

So, if you agree, I would ask @pooyaww to add their request to the linked existing issue, and close this one.

pooyaww commented 3 years ago

@Navid200 I agree. I already searched for similar issues but my choice of keywords were not similar :-). So I close it and lets continue on the same existing issue.

Navid200 commented 3 years ago

@pooyaww Thanks

tolot27 commented 3 years ago

@sulkaharo I saw this closed issue: https://github.com/nightscout/cgm-remote-monitor/issues/3337. What is the status of the implementation? @PieterGit You have created this comment: https://github.com/nightscout/cgm-remote-monitor/issues/3337#issuecomment-365446080. Does this still work with xDrip in Engineering mode?

tolot27 commented 3 years ago

But, what is common between all of these is what is requested from xDrip to upload. In my opinion, we should combine related requests. If some day a developer creates a PR for only uploading to Nightscout but not to tidepool, the combined issue will remain open because it hasn't been addressed fully.

@Navid I can follow you intention and already thought about refactoring the different sync features into a centralized sync framework. That would allow us to implement the features for all sync targets at the same time. But as long as we have target-specific issues, we should keep it separate. Otherwise, comments will be mixed and it is hard to follow.

So, if you agree, I would ask @pooyaww to add their request to the linked existing issue, and close this one.

Please keep the issues separated by the sync target/source.

tolot27 commented 2 years ago

@pooyaww It looks like the data can be synced if engineering mode is enabled. Did you try that? What is the source of the heart beat? A pebble watch or did you enable the "Smartwatch Sensors" in xDrip?

The feature should be easy to implement.

pooyaww commented 2 years ago

@tolot27 How can I enable Engineering mode? In my phone it is grayed out. The source of the heart beat is a Fitbit Versa 3 , and I have enabled Smartwatch Sensor in xDrip.

Navid200 commented 2 years ago

@pooyaww https://github.com/Navid200/xDrip/wiki/Engineering-mode

pooyaww commented 2 years ago

@tolot27 I enabled engineering mode, but nothing happened about activity level.

tolot27 commented 2 years ago

Please can you post a screenshot which shows the data collected in xDrip?

Please also enable extra logging tag for "NightscoutUploader:v" and report, if you see anything like "Processing (heartrate|steps|motion tracking) for RESTAPI" over time in the logs.