search

NightscoutFoundation / xDrip

Nightscout version of xDrip+
https://jamorham.github.io/#xdrip-plus
GNU General Public License v3.0
1.42k stars 1.15k forks source link

Disable "Restart Sensor" when incompatible #3572

Closed Navid200 closed 2 months ago

Navid200 commented 4 months ago

This PR will disable Restart Sensor for devices that cannot be restarted.

Without this, an inexperienced user may enable the setting and when the time comes for the next sensor, it may take up to half an hour for their restart attempt to fail and be obvious that something may be wrong.

I have also seen a case where the failure would happen in just a few minutes, but it would attempt another restart. The user had posted on facebook asking for help. It took quite a while to realize that they had enabled restart sensor for a new G6.

I cannot think of any case that would be at a disadvantage after including this. Can you think of a scenario where this PR would disable restart sensor where it would actually be possible?

G5 and very old G6 devices are the only ones that can benefit from enabling restart sensor. This PR does not change that. They will still be able to enable, and use, restart.

Navid200 commented 4 months ago

Testing

I enabled restart sensor before this PR with the latest Nightly and it remained enabled for a G6. I then used this PR and after 10 minutes, the setting was automatically disabled.

Unfortunately, I don't have a G5 or very old G6 to test. But, we will know as reported by users under the unlikely event that this would cause any interference.

jamorham commented 4 months ago

I think this is okay but you might want to use a higher log level like ueh or wtf to ensure that the event is very visible in the logs. It should be a one time only thing and informing the user of a forced change so I think it is good to make it very obviousl

Navid200 commented 4 months ago

Done!

Navid200 commented 3 months ago

I made the change you asked for.

Navid200 commented 2 months ago

Thanks so much for the review.

I know that reviewing someone else's work is a boring job. The person who does the work enjoys the creativity aspect. The reviewer is looking at his/her work.

It is a hard, challenging and tiring work. Thanks for doing it.