NightscoutFoundation / xDrip

Nightscout version of xDrip+
https://jamorham.github.io/#xdrip-plus
GNU General Public License v3.0
1.39k stars 1.14k forks source link

fix missing timestamp on ongoing BG notification #3579

Closed richard-dennehy closed 1 month ago

richard-dennehy commented 2 months ago

Fixes the issue described in https://github.com/NightscoutFoundation/xDrip/discussions/3578

jamorham commented 2 months ago

Thanks for this. I believe this could work but also there was at one point a problem where every update to the persistent notification would cause a notification on Android Wear. I am not sure whether enabling this could cause that to reoccur.

richard-dennehy commented 1 month ago

I don't have an Android Wear device to test this on, so I can't confirm either way, but it looks to me like the existing code here is intended to work around the potential issue you're describing

Navid200 commented 1 month ago

@PhilTU By any chance, will you be able to use your WearOS device, and a test phone, to do a test if I provide a test xDrip version to you?
I'm sorry for putting you on the spot. Please don't hesitate to decline.

PhilTU commented 1 month ago

@PhilTU By any chance, will you be able to use your WearOS device, and a test phone, to do a test if I provide a test xDrip version to you?

Could I use the built in data generator rather than a sensor? If so, yes.

Navid200 commented 1 month ago

Could I use the built in data generator rather than a sensor? If so, yes.

Yes, of course: https://navid200.github.io/xDrip/docs/FakeDataSource.html

Navid200 commented 1 month ago

@PhilTU This is the test xDrip: https://drive.google.com/file/d/1B2EuOGpxyeb80yU31vyLmZY7KJNOp0EQ/view?usp=sharing Please let me know when you have downloaded it.

With respect to the tests, please kindly confirm the following: 1- On the phone, pulling down from the top of the screen to expose the ongoing notification should show the time in addition to the value. 2- On the watch, there should not be a new notification once every 5 minutes.

Thanks


Edit:
The shared file is the latest Nightly (2024.08.02) plus this PR.
It has a different signature with respect to the official xDrip.
It is only meant for testing and should not be used for regular use.

PhilTU commented 1 month ago

Download and installed. Noted re version / signature. Awaiting arrival of mock data...

PhilTU commented 1 month ago

_20240805_211224

Confirm that notifications now include relative time stamp. WearOS tomorrow....

PhilTU commented 1 month ago

WEAROS configured and showing delta time display as expected. No notifications received as yet (of any sort) certainly not every 5 minutes as per item 2.

DSC_2375

PhilTU commented 1 month ago

I do have frequent event log entries on the phone (one or two per minute)

"AlertPlayer

13:15

setting next alert to 1 minute from now (no problem right now, but needs a fix someplace else)"

This started after snoozing a low alert...

Screenshot_20240806-132730

Navid200 commented 1 month ago

@PhilTU Thanks so much for the tests.

I have seen that log (... but needs a fix somewhere else). But, I have never got to work on it yet. I will figure it out some time.

Thanks so so much for running the tests.

richard-dennehy commented 1 month ago

Thanks, all 👍