NightscoutFoundation / xDrip

Nightscout version of xDrip+
https://jamorham.github.io/#xdrip-plus
GNU General Public License v3.0
1.41k stars 1.15k forks source link

Statistics Customization 1 #3707

Open Navid200 opened 1 month ago

Navid200 commented 1 month ago

This allows you to choose which items you would like to see on the statistics distribution page. After this PR, you will only be able to remove some of the existing items. If this is approved, we already have an open PR for adding capture rate. I will work on that to add that to the menu and give credit to the person opening that PR. Later, I would also like to add very high and very low.

Changing the pie chart to a bar chart as you requested will come later.

I chose using a simple menu so that after closing the menu, you will still be on the statistics page instead of going to the main screen.

I have avoided adding any strings so that we can make sure we are happy with English before any translation work starts.

So, why do we need this? This is not a bug fix. I think it can be useful. The distribution page is already very cluttered and we have an open PR to add yet one more item to it. This will allow one to remove what they don't need to clean up the page as they wish.

Please let me know what you think.

Navid200 commented 1 month ago
Before After
Screenshot_20241009-231358 Screenshot_20241030-231331
Navid200 commented 1 month ago

The Include menu items:

Screenshot_20241030-231740

jamorham commented 1 month ago

What are the default set of statistics which will be visible?

Is this currently inside a Scrollview? If not would it be better if it were?

Navid200 commented 3 weeks ago

https://github.com/user-attachments/assets/4c2e4db5-522f-471f-9787-be896a9b75cd

Navid200 commented 3 weeks ago

What are the default set of statistics which will be visible?

They will all be visible as they are now.
We can decide in 2 PRs after this if we want to change the defaults. But, for now, I wanted to make the changes minimal to make the review easier.

Is this currently inside a Scrollview? If not would it be better if it were?

Yes, the main window showing the parameters is already in a scrollview.
Screenshot 2024-10-31 080125