Closed jwoglom closed 3 years ago
Looks as though @jstevensog is the creator of this watchface so pinging them here.
Hi James, Working on some other fixes, so I will add this to it. Right now, I am having issues building xDrip, so until I get those sorted it might be a while. I do know there are some issues on the xDrip side where the messages to the pebble are built, so I need to get that sorted. Cheers
On Thu, Nov 1, 2018 at 2:52 AM James Woglom notifications@github.com wrote:
Looks as though @jstevensog https://github.com/jstevensog is the creator of this watchface so pinging them here.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#issuecomment-434737992, or mute the thread https://github.com/notifications/unsubscribe-auth/AIQs841YR4-M1ACVEVX__E-mw0ayWhImks5uqccggaJpZM4YEXuN .
-- John Stevens "You are how you live, not what you have."
@jstevensog is https://github.com/jstevensog/xDrip-pebble the current repo for this? If not, where could i look if I wanted to enhance the code?
Hi James, Use https://github.com/jstevensog/xDrip-Pebble-E, and please contribute back to the repo. In the past when people have made enhancements, they have not contributed back and I have struggled to merge their changes back in to get new features I have been working on into xDrip. Especially when their IDE refactors the code to suit how they like to see things, and therefore the entire code changes, and real diffs cannot be easily determined..
The main issue I am working on at the moment is the Classic Pebble support in the Clay Watch face. The "platform" dictionary entry was not understood by those that refactored the Pebble-Sync into the new muli Pebble abstraction code, and right now the trend image being built on xdrip is blowing out the available memory on the Classic watch. That is an xDrip side issue that I am working on. Otherwise the watch face is stable. Cheers
On Mon, Nov 5, 2018 at 10:36 AM James Woglom notifications@github.com wrote:
@jstevensog https://github.com/jstevensog is https://github.com/jstevensog/xDrip-pebble the current repo for this? If not, where could i look if I wanted to enhance the code?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#issuecomment-435719362, or mute the thread https://github.com/notifications/unsubscribe-auth/AIQs81CosPXE8S_M4xCD-BCfXCjHpeDwks5ur3nugaJpZM4YEXuN .
-- John Stevens "You are how you live, not what you have."
BTW, I forgot to mention. Use the "new" branch. That has the latest code. Cheers
On Thu, Nov 8, 2018 at 8:44 AM John Stevens jstevensog@gmail.com wrote:
Hi James, Use https://github.com/jstevensog/xDrip-Pebble-E, and please contribute back to the repo. In the past when people have made enhancements, they have not contributed back and I have struggled to merge their changes back in to get new features I have been working on into xDrip. Especially when their IDE refactors the code to suit how they like to see things, and therefore the entire code changes, and real diffs cannot be easily determined..
The main issue I am working on at the moment is the Classic Pebble support in the Clay Watch face. The "platform" dictionary entry was not understood by those that refactored the Pebble-Sync into the new muli Pebble abstraction code, and right now the trend image being built on xdrip is blowing out the available memory on the Classic watch. That is an xDrip side issue that I am working on. Otherwise the watch face is stable. Cheers
On Mon, Nov 5, 2018 at 10:36 AM James Woglom notifications@github.com wrote:
@jstevensog https://github.com/jstevensog is https://github.com/jstevensog/xDrip-pebble the current repo for this? If not, where could i look if I wanted to enhance the code?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#issuecomment-435719362, or mute the thread https://github.com/notifications/unsubscribe-auth/AIQs81CosPXE8S_M4xCD-BCfXCjHpeDwks5ur3nugaJpZM4YEXuN .
-- John Stevens "You are how you live, not what you have."
-- John Stevens "You are how you live, not what you have."
@jwoglom Can we close this issue? If not, would you please update as the last posts are not yours. Thanks
I am okay with closing this issue given how much time has elapsed. I never fixed the bug as I ended up switching to https://github.com/mddub/urchin-cgm instead which was more customizable.
All, Thanks for cutting my work out of the project. Regards
On Sat, 7 Aug 2021 at 01:36, James Woglom @.***> wrote:
Closed #659 https://github.com/NightscoutFoundation/xDrip/issues/659.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#event-5123563810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCCZ424CQAI5DFF5OFHJPDT3P6ORANCNFSM4GARPOGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
-- John Stevens "You are how you live, not what you have."
@jstevensog No one is cutting you out of the project.
There are too many open issues. Having hundreds of open issues removes the significance from all of them. We are organizing the issues so that we can manage and prioritize them better.
Closing an issue does not delete anything from it. Any closed issue can always be reopened.
If you can think of a better way of accomplishing this, providing a clear view to the developers what issue needs their attention the most, I am all ears.
HI Navid, I sent through a pull request that fixed these issues over two years ago. It is yet to be merged into the mainstream. Yes, there is an outstanding issue with the Pebble Classic (I don't have a working one anymore to investigate and fix it), but that should not have prevented the merge. This has been my experience over the many years I have been involved, even from the original xDrip.
I have no concern with closing off old issues. My issue is with how us old guard or outlier contributors are treated. As a T1D of 41 years, and someone who is NOT a modern programmer, I feel our inputs to the project are less valued. Regards
On Mon, 9 Aug 2021 at 12:23, Navid @.***> wrote:
@jstevensog https://github.com/jstevensog No one is cutting you out of the project.
There are too many open issues. Having hundreds of open issues removes the significance from all of them. We are organizing the issues so that we can manage and prioritize them better.
Closing an issue does not delete anything from it. Any closed issue can always be reopened.
If you can think of a better way of accomplishing this, providing a clear view to the developers what issue needs their attention the most, I am all ears.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#issuecomment-894913484, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCCZ43SVQAH5ZM4VKD3HFTT343YLANCNFSM4GARPOGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
-- John Stevens "You are how you live, not what you have."
@jstevensog Sorry, I misunderstood.
I know that xDrip has become very complicated since it supports so many different things. Everyday, someone posts on facebook asking why their sensor doesn't start. After checking everything, most of the time, it is either due to incorrect settings or the transmitter lifetime has run out or the transmitter battery has run out. People need help using xDrip. I am worried about making it more complicated than it already is. On the other hand, there are individuals who want to add more and more capabilities to xDrip.
There is a serious contradiction in the repository.
Look at this issue:
https://github.com/NightscoutFoundation/xDrip/issues/193
It's almost 4 years old! I opened a PR for it just a few weeks ago.
But, there are individuals who want to add the capability to xDrip to predict how the trajectory of the moon is going to affect their blood glucose! Of course, I am joking. But seriously, there are those who have time to code really advanced functions. Why don't they have time to fix the existing bugs first?
I call that a serious contradiction.
I'm not suggesting you are one of those individuals. What I am observing is that sometimes contradictory proposals need to be addressed, and no matter which side jamorham chooses, someone is going to get upset. It's not an easy job.
Another challenge is testing. Many like to open PRs. But, not many like to test. We cannot have one without the other.
The problem with xDrip is that there are thousands of people using it every minute of everyday. It's not a camera app or a game app. It's used for medical purposes. Even though the user has to accept they will not use it for medical purposes before being allowed to use it, we know they do. So, we have to worry about how it may be broken, if we are not careful about every merge, and cause serious harm.
If xDrip was a camera app, we could release alpha releases and ask the user community to effectively test for us.
We cannot do that with xDrip. A failed camera app may result in a bad picture. A failed xDrip can result in hypoglycemia. I don't want that to happen.
So, who is going to ensure that a merge will not break xDrip?
Again, I am observing that the position of control brings with it serious responsibility and challenge.
I am not the one making the final call. But, I open PRs. If a change I make some day causes harm to a user, I don't know if I can forgive myself. So, I support the style of merging PRs in a very careful and critical style.
I am really happy that someone else is holding the position of making the final decisions. If I was in that position, either I would go mad from people's complaints, or I would drive myself mad worrying about making a foolish decision one day causing harm to a user. I'm really happy that xDrip exists. I have been using it personally for 3 years. So, I'm happy the person in charge has kept it going on a steady trajectory for years.
Thanks for your service. If you send me a private message and give me detail about your PR, I will see if I can help. But, I can make no promises other than having a look and figuring out if I can help or not, or provide feedback.
@jstevensog Please can you link the PR here and I'll review it. I couldn't find any open PR which is related to Pebble, so far.
Thanks Mathias, I well and truly understand the complexities of keeping this project going, especially with all the feature requests. Years ago I proposed a more structured and planned method of dealing with these, which was not taken up. I am beginning to think that we need an xDrip Lite. Personally, xDrip+ has grown unwieldy and does not suit the majority of T1Ds anymore, which is where it began. It is trying to be too many things to too many people with too many use cases. We also proposed some time ago making it a pluggable application, or a series of smaller apps that could integrate. User selects the apps that suit their needs. I think the idea has merit and should be reconsidered at some point.
I feel that the ship has sailed on that pull request of years gone by. Probably closed without merging. I have gotten used to that.
On testing, well I have always exhaustively tested before I have made any pull request. The one in question had the note that I was still working on an issue with the Pebble Classic, which may have seen it closed without merge.
Anyway, it is probably way too late now. I can continue to manually merge mine, as it appears there is now a more favoured Clay style watch face to mine. I may even take a look at it myself. Or, perhaps I will look at a new Wear one when the next generation are released by Samsung. I cannot cling to the old tech forever. xBridge will die when I can no longer get G4/5 sensors and will be forced to move to the G6/7.
My current employment and workload preclude me from more active work on this project. Perhaps when I retire I can spend more time with it. Cheers
On Tue, 10 Aug 2021 at 14:43, Mathias Walter @.***> wrote:
@jstevensog https://github.com/jstevensog Please can you link the PR here and I'll review it. I couldn't find any open PR which is related to Pebble, so far.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NightscoutFoundation/xDrip/issues/659#issuecomment-895724270, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCCZ4YDF66H2NNVGKS37G3T4CU5RANCNFSM4GARPOGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
-- John Stevens "You are how you live, not what you have."
Using the "Pebble Trend Clay Version", if I have "display delta" enabled under Pebble Integration in xDrip then it will initially appear on the watchface:
But whenever the pebble watchface next refreshes (such as once a minute has passed since the last reading, or the time changes) it disappears:
If I go into the "xDrip Pebble Watchface" settings in the Pebble app and hit "save settings" at the bottom, then until the next refresh the delta will reappear.