search

Niharika0104 / TrendTrove

An E-commerce application
https://trend-trove-three.vercel.app/
Apache License 2.0
7 stars 30 forks source link

improved the search functionality of the search component #100

Closed Rajneesh2223 closed 1 week ago

Rajneesh2223 commented 2 weeks ago

PR #33
I have modified the search functionality by changing it to onclick event

vercel[bot] commented 2 weeks ago

@Rajneesh2223 is attempting to deploy a commit to the Niharika's projects Team on Vercel.

A member of the Team first needs to authorize it.

Rajneesh2223 commented 2 weeks ago

https://github.com/Niharika0104/TrendTrove/assets/127289297/87a3be17-a969-4c8c-a0e3-19c9a82d548c here is the demo of search functionality

Niharika0104 commented 2 weeks ago

@Rajneesh2223 hey..instead of performing search functionality on the cards which are there are on the home page,just redirect them to that page.Like when user types sarees and clicks on search take them /sarees page this is already set on the category cards(like when u click on saree card you will be redirected to sarees pages).You also do the same,becoz in e commerce applications like Myntra and Amazon whenever you search for something you will be redirected to a page with the products that you searched for.And remove that clear button on navbar,it's not needed.

Rajneesh2223 commented 2 weeks ago

thanks for the review i will work on it .

Rajneesh2223 commented 1 week ago

https://github.com/Niharika0104/TrendTrove/assets/127289297/2f188646-eb4e-41c2-a14c-0de02042a3bb

@Niharika0104
I have changed the implementation of search bar , please review so that i can make pull request . If any changes required I will do it

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trend-trove ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 11:04am
trend-trove-client-side ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 11:04am
Niharika0104 commented 1 week ago

image @Rajneesh2223 I merged the code your video shows something what's been deployed it shows something else.Also,when users types on sarees and clicks on search redirect them sarees page(https://trend-trove-client-side.vercel.app/Sarees) right now you are only filtering on the home page category cards.Did you push the changes to the pr?

Rajneesh2223 commented 1 week ago

@Niharika0104 Ma'am i just send you the video I havent made the pull request , that why It is showing this . Please delete that branch , then I will make new pull request to it