search

Nihilate / Roboragi

Roboragi is a Reddit bot which helps link anime, manga, and other Japanese media.
GNU Affero General Public License v3.0
167 stars 30 forks source link

Convert to using the PEP 8 style guide #16

Closed Nihilate closed 5 years ago

Nihilate commented 6 years ago

All files, functions and variables should follow the recommended Python style guide (PEP 8).

reillysiemens commented 6 years ago

@Nihilate: I'm happy to take this one if you want to assign it to me. I think it'll help make the other issues in this project a little easier to tackle.

Nihilate commented 6 years ago

Sounds good to me, go ahead :)

reillysiemens commented 6 years ago

FWIW, I think that once the majority of PEP8 violations are taken care of then linting should be added as a CI step to keep the code from regressing in that regard.

Nihilate commented 6 years ago

Definitely. I've added #53 to add a code coverage report (failing the build on low coverage might not be an option given how low it is at the moment) and #54 to add linting (with failures on regression).

reillysiemens commented 5 years ago

Hey, @Nihilate, I did some work on this last year, but since then I've come to really enjoy using Black to just auto-format code. Would you be amenable to closing this issue in favor of resolving all style issues through auto-formatting? I'd be happy to open an issue and submit a corresponding PR if that sounds good to you.

Nihilate commented 5 years ago

Hey! Sounds reasonable to me - I've been using RuboCop at work and the auto-formatter for that has been really useful. I'll open another issue.

Nihilate commented 5 years ago

I've created a new enhancement over here: https://github.com/Nihilate/Roboragi/issues/73