search

Nihilate / Roboragi

Roboragi is a Reddit bot which helps link anime, manga, and other Japanese media.
GNU Affero General Public License v3.0
167 stars 30 forks source link

Make Anilist.py more PEP8 compliant #43

Closed reillysiemens closed 6 years ago

reillysiemens commented 6 years ago

This will reduce the number of PEP8 violations (according to flake8) from 23 to 0. This is one small step towards resolving #16.

In order to keep the changeset small I just did what I could to get rid of the strict violations. I'll probably go through and do another pass later in order to fix unconventional style (i.e. detailsBySearch -> details_by_search).

This PR doesn't do anything to improve the logic (reduce McCabe complexity, etc.). That's another task I'd like to save for a later PR in order to make it easier to review these changes.

(roboragi) [17:41:54] tucker@khanti:~/Projects/Roboragi git:(master) $ flake8 roboragi/Anilist.py        
roboragi/Anilist.py:129:80: E501 line too long (81 > 79 characters)
roboragi/Anilist.py:130:80: E501 line too long (97 > 79 characters)
roboragi/Anilist.py:131:80: E501 line too long (107 > 79 characters)
roboragi/Anilist.py:175:80: E501 line too long (81 > 79 characters)
roboragi/Anilist.py:187:80: E501 line too long (92 > 79 characters)
roboragi/Anilist.py:204:80: E501 line too long (84 > 79 characters)
roboragi/Anilist.py:215:80: E501 line too long (90 > 79 characters)
roboragi/Anilist.py:220:80: E501 line too long (99 > 79 characters)
roboragi/Anilist.py:248:80: E501 line too long (117 > 79 characters)
roboragi/Anilist.py:249:80: E501 line too long (118 > 79 characters)
roboragi/Anilist.py:250:80: E501 line too long (97 > 79 characters)
roboragi/Anilist.py:265:80: E501 line too long (106 > 79 characters)
roboragi/Anilist.py:266:9: E722 do not use bare except'
roboragi/Anilist.py:271:80: E501 line too long (108 > 79 characters)
roboragi/Anilist.py:273:80: E501 line too long (108 > 79 characters)
roboragi/Anilist.py:277:80: E501 line too long (81 > 79 characters)
roboragi/Anilist.py:282:5: E722 do not use bare except'
roboragi/Anilist.py:327:80: E501 line too long (100 > 79 characters)
roboragi/Anilist.py:328:80: E501 line too long (98 > 79 characters)
roboragi/Anilist.py:334:80: E501 line too long (106 > 79 characters)
roboragi/Anilist.py:335:9: E722 do not use bare except'
roboragi/Anilist.py:341:80: E501 line too long (114 > 79 characters)
roboragi/Anilist.py:343:80: E501 line too long (112 > 79 characters)
(roboragi) [17:41:57] tucker@khanti:~/Projects/Roboragi git:(master) $ git co pep8-compliance
Switched to branch 'pep8-compliance'
Your branch is up to date with 'origin/pep8-compliance'.
(roboragi) [17:42:01] tucker@khanti:~/Projects/Roboragi git:(pep8-compliance) $ flake8 roboragi/Anilist.py
(roboragi) [17:42:05] tucker@khanti:~/Projects/Roboragi git:(pep8-compliance) $