Closed reillysiemens closed 6 years ago
Looks good. You can safely stick with purely supporting Python 3. It's currently running as 3.6.5, but I'm happy to upgrade if you're after some 3.7.0 features.
Python 3.6.5 is plenty modern enough for most of the changes I've got in mind. Now that I know that's what's running under the hood I may take more advantage of those features (especially f-strings to keep strings shorter). There might be cause to take advantage of some of the 3.7.0 features (maybe data classes?) at a later date, but I don't think that's necessary now.
I'll probably also suggest the inclusion of type annotations where possible as the Great Roboragi Cleanup progresses. :grin:
For sure, that sounds like a good idea - I've created #52 to cover it off.
PEP8 compliance (according to
flake8
) before and after the changes in this PR. This is part of addressing #16.While I was in here I also made the URL generation a little safer and cleaner using
urljoin
andquote
. This demonstrates that URL generation should still work the same in Python 2 and Python 3.For future PRs (or for this one, I guess) should I be concerned with writing Python 2/Python 3 compatible code, or can I safely write Python 3 only code?