search

Nik-Khandelwal / regsoft

This is the repository for the registration software used in the BITS Open Sports Meet (BOSM), The Annual Sport's Festival of BITS Pilani, Pilani Campus.
http://bits-bosm.org/
4 stars 0 forks source link

All Identified Issues #11

Open Arpit-24 opened 5 years ago

Arpit-24 commented 5 years ago

Introduction

The following is the list of all Identified Issues currently, go through all the issues and pick one you would like to resolve according to your assigned panels, after all the issues in your panel is fixed, try to find new issues, if you find none then move on to a new panel or ask in the group what to do next.

General

  1. Comment and document the code whatever you understand.

  2. Wherever you find BOSM 2018 written replace it by BOSM 2019 - Completed by @HarpinderJotSingh

  3. Too many Channels in pusher - decrease it to one for each panel i.e. 3 total - firewallz, controls, recnacc and subscribe to events according to it. - Currently being done by @Vishnupriya1507 and @HarpinderJotSingh

Firewallz

  1. Add Functionality - View Docs Approved by PCR in Firewallz Panel - Assigned to @HarpinderJotSingh and @abhishekspeer

  2. Add functionality - Swap members into and out of a group - Assigned to @donosco98 and @NikhilPhalange

  3. Establish Pusher Channel from Backend for updating left list of RecnAcc with people just passed from Firewallz Panel - Completed By @HarpinderJotSingh

  4. Separate Pusher Functionality from the Main Functionality so that even if Pusher crashes then also Regsoft operates properly- Assigned to @HarpinderJotSingh

  5. Sometimes one can get to all the Firewallz pages without logging in and perform some limited actions - Backend Fix - Assigned to @donosco98

  6. People of different colleges shouldn't be able to be added in a group - Assigned to @HarpinderJotSingh

Controls

  1. Edit details not working properly. - Assigned to @Vishnupriya1507

  2. Controls to RecnAcc Pusher not working - Frontend - Probably Data Format Issue - Currently assigned to no one - Seems to be working now

  3. Separate Pusher Functionality from the Main Functionality so that even if Pusher crashes then also Regsoft operates properly - Assigned to @Vishnupriya1507

  4. Sometimes one can get to all the Controls pages without logging in and perform some limited actions - Backend Fix - Currently Assigned to @Vishnupriya1507.

  5. Add Remove sports functionality to controls. - Completed by @HarpinderJotSingh.

RecnAcc

  1. Improve performance of the panel, example fetching stats, currently everything is really slow and laggy due to existence of too many pushers and too many requests - Backend Part assigned to @Polaris000

  2. Separate Pusher Functionality from the Main Functionality so that even if Pusher crashes then also Regsoft operates properly - Assigned to @KenSummon

  3. Sometimes one can get to all the RecnAcc pages without logging in and perform some limited actions - Backend Fix - Currently Assigned to no one.

  4. Subscribe to the pusher channel that Firewallz creates in the RecnAcc confirm JS and use it to add the new members just passed by firewallz to the left table. Will exactly function similar to the subscribing of controls confirm pusher channel. - Currently Assigned to @HarpinderJotSingh.

  5. Controls to RecnAcc Pusher is not working, maybe a data format issue or something else - Frontend - Doesn't seem to be an issue any longer.

PCR

  1. Change color scheme and a bit of visual revamp. Make sure not to break functionality - Currently Assigned to @niravasher.

  2. Integrate Payment Details Page Frontend and Backend - Backend Functions are written, Frontend designed by @niravasher , Page not there in regsoft currently, whoever wants to work on this, PM me so that I will mail the Frontend for integrating, Integrate them properly to make them work. - Currently assigned to @HarpinderJotSingh

  3. Separate Pusher Functionality from the Main Functionality so that even if Pusher crashes then also Regsoft operates properly - Currently assigned to @HarpinderJotSingh

  4. Sometimes one can get to the PCR pages without logging in and perform some limited actions - Backend Fix - Currently Assigned to no one.

Registration

  1. Payment through PayTM was not able to be done in BOSM 2018 due to some issues with creds or maybe just a bug in redirecting improperly and stuff. Fix all the issues with PayTM and Payment in general, and make the code such that a simple change in settings variable of PAYTM_STAGING to True or False will completely change the staging environment from Staging to Production and vice-versa, completely changing to the proper credentials, proper redirecting url's and all, both in frontend as well as backend - Currently Assigned to @abhishekspeer .

  2. We are thinking of switching to SendGrid for sending Email's, due to the reason that the mail sending api by python that we are currently using was blocked on the BITS Net (not sure if still or not). So PCR couldn't use the BITS Internet to confirm teams as if they do then mails won't be sent but the team will be confirmed but the respective team will never know, though PCR calls all the teams to inform them but still can't depend on their calling, so see for the possible implementation - Currently assigned to @abhishekspeer.

Final Comments

This will be updated as and when issues are fixed or new issues arise, Comment in the thread when you take up a new issue and work on it so that 2 people don't start working on the same issue.

SinghCoder commented 5 years ago

Picked issue number 2 under general category and made the required changes and sent the pull request

satyaim commented 5 years ago

You'da best! <3

SinghCoder commented 5 years ago

Sir :man_bow: aap great ho

SinghCoder commented 5 years ago

Issues: 1.) Right now for using pusher , a there are a lot of channels for events. Instead we can use one channel for one team(firewallz/controls/recnacc) and send multiple events on a single channel.This will in turn increase efficiency.So there will be 3/4 (not sure if PCR will require 1) channel in total. 2.) In admin panel , to remove a sport from a participant we can't just empty that row containing sport names because sport ids maintain their state and after refreshing page 2 times previous sports list reappears , so there should be a way to remove it from admin panel itself. (Right now it's resolved by going to custom user model of the participant and changing the sport id string which might contain 1 or 2 or 0 to a string with only 0s)

SinghCoder commented 5 years ago

Will be picking 4th issue under Firewallz and start working on it from tmrw.

abhishekspeer commented 5 years ago

Assigned paytm integration issue to myself.

Vishnupriya1507 commented 5 years ago

taking up 4th issue under controls panel

SinghCoder commented 5 years ago

completed controls 5th issue

SinghCoder commented 5 years ago

taking PCR 3rd issue

Vishnupriya1507 commented 5 years ago

completed issue 3 under general section

Vishnupriya1507 commented 5 years ago

issue 3 under controls section seems working.

SinghCoder commented 5 years ago

Picked PCR 2nd issue and completed. (Sent PR)

SinghCoder commented 5 years ago

is anyone doing recnacc 5th issue currently?

SinghCoder commented 5 years ago

firewallz 3rd issue and recnacc 4th done.

SinghCoder commented 5 years ago

and recnacc 5th issue is not required. I mean pusher is working there absolutely fine.