Summoner Ifrit Crimson Cyclone/Strike issue.

[tita9]

Issue: With "Advanced Summoner feature", "add Egi Astral Flow" and only "Add Mountain Buster" on, once you cast Crimson Cyclone manually, your combo buttons will turn into Crimson Strike, even if it's disabled in "add Egi Astral Flow" settings. I thought this might have to do with melee settings, but no, it just overwrites everything. Looking at the code, the branch for crimson cyclone looks like this:

At line ~630 in Combos/Pve/SMN.cs (Config.SMN_ST_Egi_AstralFlow[1] && HasEffect(Buffs.IfritsFavor) && Config.SMN_ST_CrimsonCycloneMelee && InMeleeRange()) || lastComboMove is CrimsonCyclone) // Ifrit

Whatever happens, whatever settings are turned on, if your last move was Crimson Cyclone, it overwrites your combo buttons with Strike. This is a problem in circumstances where I charge in with Cyclone, but then the boss moves away or I get knocked back for some reason, nevermind that I wouldn't expect it to overwrite my combo buttons since I have the setting turned off.

Steps to reproduce: Follow rotation until you get to ifrit, making sure that the option for ifrit's Astral Flow is turned off. Use Crimson Cyclone, notice how it overwrites combo buttons. :D

How I resolved it: At line ~630 in Combos/Pve/SMN.cs (Config.SMN_ST_Egi_AstralFlow[1] && HasEffect(Buffs.IfritsFavor) && Config.SMN_ST_CrimsonCycloneMelee && InMeleeRange()) || Config.SMN_ST_Egi_AstralFlow[1] && lastComboMove is CrimsonCyclone) // Ifrit

I understand that this comes with the caveat of cancelling my Crimson Strike if I use something else, but sometimes it's needed, and I think it's necessary to have the option to.

Suggestion: Might want to add a melee check to the strike branch too ?

I hope this helps!

[Kagekazu]

It's missing some "()", will be fixed next update :)