[BRD] Song rotation

[SugarFreeCoffee56]

Hello, I could not find any infos on this but it appears the song rotation is the same as it was in EW (Mage's Ballad ends at 12sec) instead of the new standard 3-3-12 rotation. I have tried disabling auto-song in Simple Bard but it messes up with the opener too much

[NebulousByte]

Overlooked this. Should be fixed soon.

[SugarFreeCoffee56]

Thank you very much for you work

[NebulousByte]

Fix is ready to be merged for single target. I haven't changed the logic for AoE, however. That might want to be changed in the future (I don't know).

[skolosk]

For single target and aoe it is not working as it used to. in full single button rotations it would drop songs by ending them too soon leaving them all on cooldown. it would use radiant finale without BV and sometimes with. ignores raging strikes and barrage a lot of the time - will post a separate issue for this

[NebulousByte]

I'm not sure what you mean by too soon. In the current release (not the fix mentioned above), songs are in the wrong order of when they end. The fix is waiting to be merged. In that fix, it works on 3-3-12 "Standard." That is, songs will end early. It's by design. You start with the Wanderer's Minute, 3 seconds from the end you'll go to Mage's Ballad, then 3 seconds from the end you'll go to Army's Paeon. When there's less than 12 seconds left on Army's Paeon, you go back to the Wanderer's Minute.

For AoE, the logic hasn't changed from the old version. There is only one timer check for <12 seconds.

[skolosk]

Too soon meaning - I would sit there songless with all songs on cooldown. With no manual input of my own. All through 1 button feature.

[NebulousByte]

Are you swapping between AoE and single target? The old logic for single target was still 3-3-12, even if it was in the wrong order, so you should never be songless unless you're swapping between the AoE and ST options. AoE's 12-12-12 would mean downtime.

[skolosk]

So they're not supposed to match in sloth?

[NebulousByte]

Not currently. It's always just been 12-12-12, so there's a lot of overlap. E.g. if you're in a dungeon and you've spent all your songs on a trash pull, you're likely going to be songless with songs on cooldown going into a boss fight, or you're in the middle of a boss fight and you swap to AoE to deal with adds. It's always been like this. Though I can certainly change it so they work on the same timings.

[skolosk]

I never used/heard of 12-12-12 in dungeons. I heard of dropping WM and starting with ballad, but now with PP being aoe and barrage new ability, everything should line up. single target and aoe. Part of why they did what they did in DT was to fix that discrepancy in dungeons.

Would it be possible for you to add raid buffs to AoE single button as well? If not used that way, the whole dungeon ends up with misaligned buffs under different songs..

appreciate your help

[NebulousByte]

Will add in the logic to AoE that ST has for songs and add in PP. Will make a new PR later once tested.

[SugarFreeCoffee56]

If you need help testing I can try

[qnesp1987]

new standard is 3-3-9 and AoE = sing;e target. Wanderer's Minuet is now the strongest song for AoE. It isnt 3 -3-12

also AoE has never been 12-12-12 - that would mean a brd would deliberately have to plan a rotation that would leave them songless. On the balance BRD resources t says 3-3-9

Thank you

[NebulousByte]

also AoE has never been 12-12-12

I never said that's the way it should have been, I said that's the way it is/was coded in Sloth. You'd have to ask the person who originally did that what their rationale was.

As for the timings, order, and AoE, I'm fixing that. Be patient.