search

Nik-Potokar / XIVSlothCombo

XivCombo for very lazy gamers
GNU General Public License v3.0
274 stars 315 forks source link

[DRG] Chaos Spring/Heavens Thrust Sometimes Loops #1721

Closed Beanslash closed 2 months ago

Beanslash commented 3 months ago

Sometimes the DRG rotation with all advanced settings will loop either combo. It looks to break after being out of melee distance for extended amounts of times. This will sometimes cause Lance Charge to drift since it looks like it won't pop it until Power Surge is applied which sometimes it wont use due to repeating Heavens Thrust. Suggesting it just alternates between Heavens Thrust/Chaos Spring combo at all times regardless of duration left on DoT/Power Surge. Below is an M2S log where the only manual input was Piercing Talon during certain mechanics.

Analysis: https://xivanalysis.com/fflogs/a:W9d6TkLm3wJbYnyM/45/1923 FFLog: https://www.fflogs.com/reports/a:W9d6TkLm3wJbYnyM#fight=45&type=damage-done&source=1923

Akechi-kun commented 3 months ago

Known bug that for some reason is fixed by disabling then re-enabling the plugin.

Beanslash commented 3 months ago

Disabled and reenabled but looks to still opt to double Chaos Spring combo on the dummy when out of range for a few GCDs instead of just continuing with Heavens Thrust combo when back to melee range. Working as intended?

Kagekazu commented 3 months ago

ill have an in depth look once my drg is lvl 100, i know for me it just rotates both on lvl 92

Kagekazu commented 3 months ago

Disabled and reenabled but looks to still opt to double Chaos Spring combo on the dummy when out of range for a few GCDs instead of just continuing with Heavens Thrust combo when back to melee range. Working as intended?

can u get me a log of it happening? since i cant replicate it at all on my end

Beanslash commented 3 months ago

Disabled and reenabled but looks to still opt to double Chaos Spring combo on the dummy when out of range for a few GCDs instead of just continuing with Heavens Thrust combo when back to melee range. Working as intended?

can u get me a log of it happening? since i cant replicate it at all on my end

https://xivanalysis.com/fflogs/a:ArvdK6gaF4bZhzwY/2/1 It's on a dummy if that makes a difference. Wasn't able to get it to replicate it looping Heavens Thrust but it will loop Chaos Spring when unable to keep uptime. Walked outside of melee range of the dummy for a bit to replicate.

Kagekazu commented 3 months ago

ofcourse it will loop chaos thrust when u dont have uptime, it tries to keep ur buff and debuff up..

Beanslash commented 3 months ago

Right but it seems very strict in terms of refreshing it. During actual fights it feels like if you're out of range for even about a GCD or two(M3S KB towers for example) it'll just Chaos Spring leading to refreshing it significantly earlier, image

Kagekazu commented 3 months ago

Right but it seems very strict in terms of refreshing it. During actual fights it feels like if you're out of range for even about a GCD or two(M3S KB towers for example) it'll just Chaos Spring leading to refreshing it significantly earlier, image

at the moment it will go to chaos spring chain when ur chaos dot is lower than 5 GCD's ( what u need to get do a full combo from heavens thrust) .

Beanslash commented 3 months ago

Ah gotcha, Figured it was intentional just definitely felt really strict. Better than repeating Heavens Thrust which disabling and re enabling did fix. Thanks.

Kagekazu commented 3 months ago

Ah gotcha, Figured it was intentional just definitely felt really strict. Better than repeating Heavens Thrust which disabling and re enabling did fix. Thanks.

i can change this so it just checks if u have the debuff on ur target or if ur power surge is below 15 secs ( which is about the same as 1 combo chain)

Beanslash commented 3 months ago

Ah gotcha, Figured it was intentional just definitely felt really strict. Better than repeating Heavens Thrust which disabling and re enabling did fix. Thanks.

i can change this so it just checks if u have the debuff on ur target or if ur power surge is below 15 secs ( which is about the same as 1 combo chain)

I personally think the debuff check would work great.

Beanslash commented 2 months ago

@Kagekazu Tested the new PR and it works great. Thanks for your hard work! Only thing I've noticed is that the Dynamic True North wasn't working. Didn't test it on other melees but wasn't working for DRG so not sure if it's tied to these changes.

Kagekazu commented 2 months ago

@Kagekazu Tested the new PR and it works great. Thanks for your hard work! Only thing I've noticed is that the Dynamic True North wasn't working. Didn't test it on other melees but wasn't working for DRG so not sure if it's tied to these changes.

Hmm, It should work, I'll test it out and make some changes today if needed!

Kagekazu commented 2 months ago

@Kagekazu Tested the new PR and it works great. Thanks for your hard work! Only thing I've noticed is that the Dynamic True North wasn't working. Didn't test it on other melees but wasn't working for DRG so not sure if it's tied to these changes.

U were correct, this is fixed in latest commit!