search

Nik-Potokar / XIVSlothCombo

XivCombo for very lazy gamers
GNU General Public License v3.0
265 stars 306 forks source link

[PLD] Holy Spirit from Divine Might is used too quickly #1813

Open program-ui opened 1 week ago

program-ui commented 1 week ago

For paladin's holy spirit, sometimes we want to save it in case for uptime when we have to disengage for mechanics. Right now, the holy spirit opinion uses DMHS even when the buff is not expiring and you can still do the Fast Blade Combo. It would be nice to only use DMHS when the buff is expiring + royal authority is the next GCD + no more Atonement procs so we can save DMHS for melee uptime.

Kaeris-Tempest commented 1 week ago

It should already behave this way. Sloth will "hold" Divine Might until the buff is either expiring (<10s) or about to be refreshed (next GCD is Royal Authority).

There are edge cases. Divine Might will be consumed prematurely if, and only if:

program-ui commented 1 week ago

The idea is to hold and save DMHS as long as possible so it can be used for disengaging. Right now I think DMHS is used before the atonement procs are used (because it is programmed to be used during 2 mins buffs?). I definitely would prefer to save DMHS for disengagement rather than use it during party raid buffs.

Kaeris-Tempest commented 1 week ago

The idea is to hold and save DMHS as long as possible so it can be used for disengaging.

Like I clarified before, it already does this in most cases. Part of the responsibility also falls on the user avoid disengaging as much as possible. Disengaging also means no auto-attacking, which is a significant DPS loss. You should be avoiding this at all costs.

Right now I think DMHS is used before the atonement procs are used

It's not, except when trying to fit it inside burst windows. The logic does its best to accommodate burst optimization while leaving room for ranged uptime when possible.

I definitely would prefer to save DMHS for disengagement rather than use it during party raid buffs.

To clarify, you want to delay using Divine Might even during burst windows? Because this would lead to noticeable DPS loss in virtually any party setting.