search

Nike-Inc / brickflow

Pythonic Programming Framework to orchestrate jobs in Databricks Workflow
https://engineering.nike.com/brickflow/
Apache License 2.0
185 stars 39 forks source link

Feature remove cdktf #18

Closed asingamaneni closed 1 year ago

asingamaneni commented 1 year ago
  1. Modified onpush.yaml to remove cdktf and node installations
  2. Modified .gitignore and pre-commit-config.yaml and readme.md
  3. Modified CONTRIBUTORS file to add linkedin profiles
  4. Modified code and tests to remove CDKTF
  5. Modified code to make argument changes for Databricks version v0.203.0
  6. Moving Sync to projects (bf projects sync --project brickflow_test_workflows --watch --debug)

Tests:

image

image

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 67.85% and project coverage change: +0.22% :tada:

Comparison is base (4c90cd9) 88.19% compared to head (033879f) 88.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #18 +/- ## ========================================== + Coverage 88.19% 88.42% +0.22% ========================================== Files 24 22 -2 Lines 3415 3163 -252 ========================================== - Hits 3012 2797 -215 + Misses 403 366 -37 ``` | [Files Changed](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc) | Coverage Δ | | |---|---|---| | [brickflow/\_\_init\_\_.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L19faW5pdF9fLnB5) | `91.41% <ø> (-0.41%)` | :arrow_down: | | [brickflow/cli/bundles.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9idW5kbGVzLnB5) | `52.45% <0.00%> (ø)` | | | [brickflow/cli/commands.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9jb21tYW5kcy5weQ==) | `80.95% <ø> (+22.88%)` | :arrow_up: | | [brickflow/cli/constants.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9jb25zdGFudHMucHk=) | `100.00% <ø> (ø)` | | | [brickflow/codegen/\_\_init\_\_.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NvZGVnZW4vX19pbml0X18ucHk=) | `87.87% <ø> (-3.55%)` | :arrow_down: | | [brickflow/engine/\_\_init\_\_.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2VuZ2luZS9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [brickflow/engine/workflow.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2VuZ2luZS93b3JrZmxvdy5weQ==) | `100.00% <ø> (ø)` | | | [brickflow/cli/projects.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9wcm9qZWN0cy5weQ==) | `57.78% <58.33%> (+0.29%)` | :arrow_up: | | [brickflow/cli/\_\_init\_\_.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9fX2luaXRfXy5weQ==) | `51.35% <80.00%> (-3.80%)` | :arrow_down: | | [brickflow/cli/configure.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2NsaS9jb25maWd1cmUucHk=) | `39.08% <100.00%> (+1.08%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/18/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.