Nike-Inc / brickflow

Pythonic Programming Framework to orchestrate jobs in Databricks Workflow
https://engineering.nike.com/brickflow/
Apache License 2.0
187 stars 44 forks source link

Task Dependency Sensor doesn't account for Execution delta #30

Closed bsangars closed 1 year ago

bsangars commented 1 year ago

Describe the bug Task Dependency sensor (brickflow_plugins/airflow/operators/external_tasks/TaskDependencySensor) which pings upstream airflow clusters for state [success, failure etc] doesnt account for Execution delta window meaning when we ping the airflow cluster it is poking for success at same time instead of the execution delta window To Reproduce Steps to reproduce the behavior:

  1. create a workflow with a dependency on the airflow cluster.
  2. update okta_conn_id in the secrets
  3. run the workflow to check for upstream airflow(dag/task) success
  4. Would fail after timeout

Expected behavior Should succeed once a success execution is found for a dag within the execution window.

Screenshots If applicable, add screenshots to help explain your problem.

Cloud Information

Desktop (please complete the following information):

Additional context Add any other context about the problem here.