Closed BrendBraeckmans closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.01%
:tada:
Comparison is base (
5a10093
) 88.44% compared to head (33e3501
) 88.45%. Report is 1 commits behind head on main.:exclamation: Current head 33e3501 differs from pull request most recent head 34ab524. Consider uploading reports for the commit 34ab524 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Make node_type_id optional as it's otherwise impossible to create a cluster from resources in a pool
Related Issue
https://github.com/Nike-Inc/brickflow/issues/43
Motivation and Context
This would help all teams that are using brickflow and want to run some of their jobs on clusters taking instance from cluster pools for performance, SLA or other reasons
How Has This Been Tested?
I succesfully deployed my workflow to Databricks where it made use of the instances provided by a pool. I ran 'make check' to align with the formatting standards. I ran 'make test' and everything was successfull
Screenshots (if appropriate):
When create cluster with instances from pool
and run
brickflow deploy
, on wheel containing my commits, it succeedsThe same occurs when also specify
driver_instance_pool_id
Types of changes
Checklist: