add run_if param to TaskSettings

grigoriy835 commented 1 year ago

Enable conditional runs databricks feature

Description

added run_if option to TaskSettings class

How Has This Been Tested?

tests updated to cover new functional, dev test by deploying my brickflow project to databricks

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

asingamaneni commented 1 year ago

Can you please add examples to the documentation as well.

asingamaneni commented 1 year ago

@grigoriy835 The build failed. Can you please do make cov and may be format the files using make fmt so that code is aligned on the linting standards.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (03cc0f2) 88.45% compared to head (1da52a3) 88.48%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 88.45% 88.48% +0.02% ========================================== Files 22 22 Lines 3179 3187 +8 ========================================== + Hits 2812 2820 +8 Misses 367 367 ``` | [Files](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc) | Coverage Δ | | |---|---|---| | [brickflow/\_\_init\_\_.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L19faW5pdF9fLnB5) | `91.41% <ø> (ø)` | | | [brickflow/engine/task.py](https://app.codecov.io/gh/Nike-Inc/brickflow/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nike-Inc#diff-YnJpY2tmbG93L2VuZ2luZS90YXNrLnB5) | `94.91% <100.00%> (+0.10%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grigoriy835 commented 1 year ago

@stikkireddy please can you check your requested changes?

stikkireddy commented 1 year ago

@grigoriy835 thanks for the contribution!

Nike-Inc / brickflow