Closed BrendBraeckmans closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5a10093
) 88.44% compared to head (196db3b
) 88.49%. Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR contains following changes
--no-autodetect
in make check of Makefile cause otherwise prospector needs django which isn't used. I needed this to getmake check
running on my machine but not sure what you guys think of thisRelated Issue
Motivation and Context
At this point in time the WorkflowDependencySensor doesn't work at all which blocks multiple users of brickflow. I know that in the future this functionality will not be needed anymore in brickflow as it's become Databricks native so can be achieved through asset bundles. This however needs development at brickflow side so this PR fixes the issues we face till this is done.
How Has This Been Tested?
I build my own wheel based on this PR and tested it extensively on a workflow making use of the WorkflowDependencySensor
Screenshots (if appropriate):
Types of changes
Due to the change in how the token gets handled in
WorkflowDependencySensor
users will need to adapt their code when they upgrade. I however think there are no users of this feature at the moment as it's not working right now.Checklist: