Nike-Inc / brickflow

Pythonic Programming Framework to orchestrate jobs in Databricks Workflow
https://engineering.nike.com/brickflow/
Apache License 2.0
183 stars 39 forks source link

added fix for import block type to support both str and int and added… #78

Closed stikkireddy closed 8 months ago

stikkireddy commented 8 months ago

Description

Fix #74

Motivation and Context

Import block support both str and int types as valid ids and added test.

How Has This Been Tested?

Unit testing added for constructing the object and generation of the terraform import file.

Types of changes

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (85ee1cd) 93.33% compared to head (9abe24e) 93.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== + Coverage 93.33% 93.37% +0.04% ========================================== Files 22 22 Lines 4919 4923 +4 ========================================== + Hits 4591 4597 +6 + Misses 328 326 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.