Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials
Apache License 2.0
925 stars 263 forks source link

Doesn't work correctly on Windows 10 when the binary installed is named python #191

Open chizou opened 4 years ago

chizou commented 4 years ago

gimme-aws-creds doesn't execute correctly when I install python 3.7.6 32-bit on Windows 10. The installer installs the binary as python instead of python3. So this check ends up failing: https://github.com/Nike-Inc/gimme-aws-creds/blob/master/bin/gimme-aws-creds.cmd#L8

If I modify the file to search for python instead of python3, it works correctly. Some logic probably needs to be added to check if python3 isn't detected, to look for python. Unfortunately, I don't know the syntax of whatever language that is in the .cmd file.

daniel-harrison-cko commented 4 years ago

I have the same error message.

Changing this line to the following fixes the problem for me:

    for %%j in (python.%%i) do (

My Python installation details I installed Python from the official Python 3.7.4 windows installer and below is my build info.

Python 3.7.4 (tags/v3.7.4:e09359112e, Jul 8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)] on win32

kondal508 commented 4 years ago

Had same issue it gives blank output on windows10 with official python 3.9 version. I have modified to look for python instead of python3. It started to work