Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials
Apache License 2.0
925 stars 263 forks source link

MFA String Matching for more languages #341

Closed kabakakao closed 2 years ago

kabakakao commented 2 years ago

Match all? language specific strings for MFA verification

Description

With this pull-request I created a tuple with all? language specific MFA extra verification strings

Related Issue

Fixes #339 Fixes #317

Motivation and Context

People with other language than "English" in Okta-Webfrontend get an error, because the regex match did not get, that mfa is needed

How Has This Been Tested?

I tested it with several languages and it works for me

Types of changes

Checklist:

bobby-lin commented 2 years ago

@bwynsm Can you approve this PR? I think it is a straightforward change to add more language support

kabakakao commented 2 years ago

@bwynsm would it be possible to release a new version, that it can be used? That would be nice