Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials
Apache License 2.0
925 stars 263 forks source link

Unpin python-dateutil #346

Closed flying-sheep closed 2 years ago

flying-sheep commented 2 years ago

Description

Unpins a restrictive upper dependency bound

Related Issue

Fixes #313

Motivation and Context

Since there‘s no explanation why your python-dateutil requirement is pinned, I’m going to assume it’s no longer an issue.

Upper bounds are bad if not absolutely necessary: https://iscinumpy.dev/post/bound-version-constraints/

How Has This Been Tested?

I’m going to rely on your CI

Types of changes

Checklist:

rabbittsoup commented 2 years ago

I would think a dateutil requirement should remain in requirements in some form if gimme-aws-creds uses dateutil somewhere. Just not pinned as restrictively.

rabbittsoup commented 2 years ago

Interesting, a quick search for dateutil doesn’t seem to show it being used in the code at all. If that’s true, then, yeah, it should be removed.

alexlatchford commented 2 years ago

Thanks @flying-sheep for the PR, any chance you could push out a release with this change @bwynsm? We currently have some other dependencies (notably jupyter-client) backpinned because of this change so hoping to clear this up if possible!