This corrects an issue with the validation of the org url and app url…

magni2000 commented 1 year ago

… when using action-configure

This is correcting the logic that is used in the config.py file to validate if the url contains one of the valid okta domains.

Description

The updated code will not correctly validated that the url provided by the user for the okta org or the app url will contain one of the elements contained in the allowlist. The validation logic that is in the code will always return false.

Motivation and Context

We currently utilize the --action-configure feature for our employees to properly configure gimme-aws-creds for the first time utilization. We can provide a work around, but would prefer to utilize the functionality provided by the project already.

How Has This Been Tested?

I was able to test with mutliple urls, both those that contain the one of the domains in the allow list and urls that do not contain those domains. The logic is now returning a proper true or false using the desired validation criteria.

Screenshots (if appropriate):

valdationscreenhot

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

magni2000 commented 1 year ago

@epierce can you review this pull request? It is a fix to bug that was introduced with a recent merge in November.

epierce commented 1 year ago

The changes look good and are working for me. Thanks!

Nike-Inc / gimme-aws-creds