Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials
Apache License 2.0
920 stars 262 forks source link

fix for double challenge factor #385

Closed kabakakao closed 1 year ago

kabakakao commented 1 year ago

These changes had to be made, if you need the stepup-factor. Without these changes the challenge "correctAnswer" isn't shown the second time

Description

Instead of setting the function _print_correct_answer to None this change checks if the answer is the same as in the first attempt.

Motivation and Context

In our organization we are using the "correctAnswer" Factor. And the stepup-auth is needed. So the factor came up twice. Without these changes it isn't shown the second time

Types of changes

Checklist:

kabakakao commented 1 year ago

@epierce any chance to get it merged? It is a really annoying issue for us. Please let me know, if I have to change anything.

kabakakao commented 1 year ago

This is Not needed anymore due to Code changes