Closed markjreed closed 1 year ago
Seeing the same. Now sees it as a single login.
It appears that AWS changed the design of the role selection page in the login workflow. Guessing that gimme-aws-creds will have to be updated to scrape the role names from this new design.
setting resolve_aws_alias = false
is working for us as a local authentication workaround, returning the role arn in the console. this wont help if you rely on that alias resolution.
I was hoping a quick regex update in the scraping would fix it but the new page returned is some NextJS mess...
looks like AWS might have just reverted the change?
looks like AWS might have just reverted the change?
I saw that, and was gonna say something, but then I refreshed and new design was back again - maybe it's some sort of canary percentage based roll-out?
Seems to be consistently back to vanilla html.
I stashed a response and have what I think could be the basis of a fix:
Summing it all up:
We were impacted by this change since we have a wrapper utility (https://github.com/ArcadiaPower/axolotl) that depends on gimme-aws-creds for performing the SAML login to obtain credentials. I also managed to snag the response of the new NextJS page this morning prior to AWS reverting and worked out a fix that parses the same values from the new JSON metadata.
Unless I hear differently I'll get a PR drafted for when/if AWS moves forward with the switch to the new login page.
Opened a draft PR (linked automatically by Github above) that accounts for the new NextJS page. My approach conditionally falls back to the existing parsing strategy if the NextJS metadata isn't present which should allow this to merge/release ahead of AWS trying Round 2 of the new login page.
I do still want to update test cases prior to getting it merged, but I pushed my changes in case anyone cares to comment and/or needs a patch faster than it takes to get a main release cut.
when is the next release with this fix?
Expected Behavior
gimme-aws-creds should see all of my assigned roles and prompt
Current Behavior
gimme-aws-creds sees only a single role (first one on page)
Possible Solution
Need to adjust parsing of SAML login page HTML
Steps to Reproduce (for bugs)
Context
Lots of IaC with hard-coded AWS_PROFILE values that include account aliases, now must be changed to account-id (or workflow changed to specify profile names)
Your Environment
App Version used:
2.7.1
Operating System and version: macOS 13.4.1