Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials
Apache License 2.0
919 stars 262 forks source link

Replace getpass with ui.input(hidden=True) #429

Closed jbgosselin closed 11 months ago

jbgosselin commented 11 months ago

Description

I'm currently trying to automate gimme-aws-creds in a python script. I admire the idea of the gimme_aws_creds.ui.UserInterface class that helps a lot in automating user input. I found that some places in the code was directly calling getpass.getpass() and not using the provided UserInterface. Replacing those calls with the proper UserInterface.input(hidden=True).

Related Issue

Fixes #428

Motivation and Context

Allowing developers subclassing gimme_aws_creds.ui.UserInterface for automation to provide inputs for password themselves.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist: