Closed guinuxbr closed 3 months ago
I'm not able to replicate this - comments starting with "#" and ";" stay in the file unless I run --configure
(which I would expect to clear comments and write out a fresh config block)
Thanks for checking, @epierce.
I'll test again next week and let you know.
Closing this since we haven't heard anything back
Sorry, mate. I thought I had already answered this. I've tested the latest version, and it worked fine. I don't know what caused the issue before. Thank you anyway.
Expected Behavior
Considering that configparser syntax is being used, I was expecting to be able to have comments in the file
.okta_aws_login_config
by using "#" or ";"Current Behavior
As soon as I run the container, all comments added to
.okta_aws_login_config
are overwritten.Possible Solution
It would be nice to handle the comments possibly ignoring the characters "#" and/or ";" while parsing the configuration file.
Steps to Reproduce (for bugs)
gimme-aws-creds -p profile_name
.okta_aws_login_config
and the comments are gone.Context
This is a "nice to have" when you are dealing with several different profiles. It would be nice to have the ability to add comments to make it easier to understand details about the AWS Role being assumed. It would also help to onboard new colleagues when sharing
.okta_aws_login_config
.Your Environment
2.7.2
Docker Engine 24.0.6
Windows 10 Pro 22H2