Got exception when running on windows 10

Nike-Inc / gimme-aws-creds

A CLI that utilizes Okta IdP via SAML to acquire temporary AWS credentials

Apache License 2.0

919 stars 262 forks source link

Got exception when running on windows 10 #435

Closed petervalencic closed 2 months ago

petervalencic commented 10 months ago

Expected Behavior

Following the instructions from this page https://www.doyler.net/security-not-included/gimme-aws-creds I am able to install gimme-aws-creds but when running it got some issues described below

Current Behavior

Steps to Reproduce (for bugs)

Install python from the official page (3.12)
Verify paths with where python and where pip
Install gimme-aws-creds pip3 install --upgrade gimme-aws-creds
Execute gimme-aws-creds

Your Environment

App Version used: Python 3.12
Environment name and version:
Operating System and version: Windows 10

kbiglercc commented 10 months ago

I removed the method_whitelist parameter and it resolved the issue. Per the urllib3 documentation it seems allowed_methods is the correct parameter but POST is not an acceptable value. Could be something they missed on their end, but either way I don't think it will work here.

https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#urllib3.util.Retry

I can create a PR but I've only tested on Windows with python3.11.

its-mirus-lu commented 6 months ago

It looks like they've fixed it in code here but there hasn't been a release for this project since the fix was made.

Until they release a newer version of the python module, one way to update to get the new code would be to call pip3 install --upgrade git+git://github.com/Nike-Inc/gimme-aws-creds.git as outlined in the readme of this project.

epierce commented 2 months ago

fixed in 2.8.2