Keep original `force_classic` value during profile inheritance

noamcohen97 commented 3 months ago

Description

When inheriting a profile stating force_classic = False this value is getting overridden by the default value force_classic = True if the child profile does not explicitly set force_classic = False as well

Related Issue

fixes #463

Motivation and Context

How Has This Been Tested?

Added a test

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

epierce commented 3 months ago

Looks good - Thanks!

noamcohen97 commented 3 months ago

@epierce When can we expect this to be released?