search

Nike-Inc / hal

hal provides an AWS Lambda Custom Runtime environment for your Haskell applications.
BSD 3-Clause "New" or "Revised" License
241 stars 13 forks source link

Fix dynamic context parsing #71

Closed mbj closed 3 years ago

mbj commented 4 years ago
IamfromSpace commented 4 years ago

Great catch and thanks for the PR!

I haven’t merged this yet, as I’m hoping to backport this to all versions. Hopefully you don’t mind me messing with the commits a bit here.

It’s a good point on Text -> Text. I gave it a thought at the time, but clearly not enough, because here we are.

From here I’m thinking that potentially this could be introduced without breaking changes by either typing the Internal modules or even exposing a combinators that choose between a typed or untyped Context.

mbj commented 4 years ago

@IamfromSpace feel free to change the commit as you please.

IamfromSpace commented 3 years ago

Closing this for #72, which cherry-pick's this commit and then backports to all versions.