search

Nike-Inc / hal

hal provides an AWS Lambda Custom Runtime environment for your Haskell applications.
BSD 3-Clause "New" or "Revised" License
241 stars 13 forks source link

Reduce envy usage for greater compatibility #77

Closed IamfromSpace closed 3 years ago

IamfromSpace commented 3 years ago

Envy is a pretty handy library that does some pretty cool things--however, it's got a bit of churn in its versioning, and we really don't use that much from it. It makes more sense to simply replace the functionality so that broad support of LTSes is simpler.

endgame commented 3 years ago

Another reason to remove envy, if you're still on that train: the version churn causes hal to be marked as broken in nixpkgs, which is unfortunate. (It compiles if bounds are relaxed, but if it's not needed, then better to not have it.)

IamfromSpace commented 3 years ago

All green! That's very exciting. @endgame thank you for getting those bounds fixed.

Any thoughts on which we should merge first? I'm leaning towards this one, as it'll get the other PR all green as well.

endgame commented 3 years ago

I would've said the opposite, because merging/rebasing smaller commits is generally easier than larger ones. But I think either will work.

endgame commented 3 years ago

I missed what you said, that merging this should green the other. That's a good reason to do this first.