search

Nike-Inc / koheesio

Python framework for building efficient data pipelines. It promotes modularity and collaboration, enabling the creation of complex pipelines from simple, reusable components.
https://engineering.nike.com/koheesio/
Apache License 2.0
602 stars 29 forks source link

[BUG] Step get attribute is passing on missed attributes and shadow excpetions #81

Closed mikita-sakalouski closed 2 weeks ago

mikita-sakalouski commented 1 month ago

Describe the bug

The __getattr__ method in the Step class was returning None when trying to access unavailable attributes in child classes. Additionally, it was shadowing exceptions that should have been raised.

Steps to Reproduce

  1. Create a child class inheriting from Step.
  2. Attempt to access an unavailable attribute in the child class.
  3. Observe that None is returned instead of an exception being raised.

Expected behavior

An AttributeError should be raised when trying to access an unavailable attribute in the Step child classes.

dannymeijer commented 2 weeks ago

Fixed in #82 - will be part of upcoming 0.9 release