Nike-Inc / spark-expectations

A Python Library to support running data quality rules while the spark job is running⚡
https://engineering.nike.com/spark-expectations
Apache License 2.0
148 stars 32 forks source link

[BUG] It's not possible to pass authentication for the email notifications #54

Open bilsbernd opened 8 months ago

bilsbernd commented 8 months ago

Describe the bug Trying to use the email notifications module, it seems that there is no parameter foreseen to pass the credentials to login to the smtp server. Only the email address from can be specified.

To Reproduce When running the algorithm with the user_config parameter specified (smtp host, port & email address), it fails stating that 'the client is not authenticated to send mail. Not only the mailing fails, but the entire DQ run fails.

Expected behavior In the email source code, it seems that the adding a line of code to authenticate the server will resolve the issue (server.login(address_from, PASSWORD). This password will need to be added as a user_config parameter or elsewhere.