search

Nikea / VTTools

Library that has utility tools for VisTrails
Other
1 stars 8 forks source link

Fixed tifffile issue #36

Closed celiafish closed 9 years ago

celiafish commented 9 years ago

Fixed pims.extern.tifffile dependency when importing tools to VisTrails.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling cc7b23ca272e2e98287e90c0f27369088def4023 on celiafish:master into 805695ff4e6a67c5e4cec69b491ce04739b73084 on Nikea:master.

ericdill commented 9 years ago

@tacaswell has pims been fixed so that this problem doesn't exist any more?

tacaswell commented 9 years ago

The problem is that pims no longer bundles tifffile

celiafish commented 9 years ago

So I guess some one'd go ahead and merge the request?

tacaswell commented 9 years ago

I think only the change to the import s is needed, can you revert the changes to the modules exposed?

On Sat, Dec 6, 2014, 18:28 Wei Xu notifications@github.com wrote:

So I guess some one'd go ahead and merge the request?

— Reply to this email directly or view it on GitHub https://github.com/Nikea/VTTools/pull/36#issuecomment-65919306.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 9d5096d9952e67df0d051f00caca714c07d4e679 on celiafish:master into 805695ff4e6a67c5e4cec69b491ce04739b73084 on Nikea:master.

celiafish commented 9 years ago

I modified my own repo. If I pull, will it generate a new request? How do I make the change affect this pull request? :S

tacaswell commented 9 years ago

Adding the commit to the branch you started the PR from automatically adds it to the PR (which tracks the branch not the commit).