Closed ericdill closed 9 years ago
@ericdill , @tacaswell wanted me to return the artists added in each plotting function ( in my earlier PR #66) Are you going to do that?
@sameera2004 yes, i am planning on doing that
@ericdill sure thanks
Are we going to add ipython-notebook examples in this repo too?
@ericdill these fucntions are fine, much better! Thanks
@sameera2004 can you review these changes?
@ericdill what is the status of this?
This should be ready to go. I updated the speckle_plotting notebook in scikit-xray/scikit-xray-examples#29
@ericdill speckle-plotting.ipnb' in this PR hasn't updated, one in skray-examples is working, the problem due to changes in
roi.mean_inetnsity' function,
error is at roi_data converting to data frame, can you please add the same notebook here?
@ericdill speckle-plotting.ipnb
in this PR hasn't updated can you add the same one you have in scikit-xray-examples
. This ipnb
is not working
I am going to remove the ipython notebook from this PR. I am :-1: on having the same notebook in two places. That seems like a recipe for things getting horribly out of sync, right?
Yes sure
Ok, rebased with edits to get rid of the notebook from this PR
@ericdill speckle_plotting_tools looks good, can you fix this Travis fail?
Yes I could, but it is failing because there is no .travis file. I will create one in a separate PR
travis is failing because it has no idea what to do, not because there is a specific error
Apparently github has freaked out. All of these commits are already in master...
supersedes #66