Nikea / xray-vision

Visualization widgets and plotting helpers targeted at X-Ray Sciences
Other
5 stars 13 forks source link

ENH: Speckle plotting tools #68

Closed ericdill closed 9 years ago

ericdill commented 9 years ago

supersedes #66

sameera2004 commented 9 years ago

@ericdill , @tacaswell wanted me to return the artists added in each plotting function ( in my earlier PR #66) Are you going to do that?

ericdill commented 9 years ago

@sameera2004 yes, i am planning on doing that

sameera2004 commented 9 years ago

@ericdill sure thanks

sameera2004 commented 9 years ago

Are we going to add ipython-notebook examples in this repo too?

@ericdill these fucntions are fine, much better! Thanks

ericdill commented 9 years ago

@sameera2004 can you review these changes?

sameera2004 commented 9 years ago

@ericdill what is the status of this?

ericdill commented 9 years ago

This should be ready to go. I updated the speckle_plotting notebook in scikit-xray/scikit-xray-examples#29

sameera2004 commented 9 years ago

@ericdill speckle-plotting.ipnb' in this PR hasn't updated, one in skray-examples is working, the problem due to changes inroi.mean_inetnsity' function, error is at roi_data converting to data frame, can you please add the same notebook here?

sameera2004 commented 9 years ago

@ericdill speckle-plotting.ipnb in this PR hasn't updated can you add the same one you have in scikit-xray-examples. This ipnb is not working

ericdill commented 9 years ago

I am going to remove the ipython notebook from this PR. I am :-1: on having the same notebook in two places. That seems like a recipe for things getting horribly out of sync, right?

sameera2004 commented 9 years ago

Yes sure

ericdill commented 9 years ago

Ok, rebased with edits to get rid of the notebook from this PR

sameera2004 commented 9 years ago

@ericdill speckle_plotting_tools looks good, can you fix this Travis fail?

ericdill commented 9 years ago

Yes I could, but it is failing because there is no .travis file. I will create one in a separate PR

ericdill commented 9 years ago

travis is failing because it has no idea what to do, not because there is a specific error

ericdill commented 9 years ago

Apparently github has freaked out. All of these commits are already in master...