search

Niketkumardheeryan / ML-CaPsule

ML-capsule is a Project for beginners and experienced data science Enthusiasts who don't have a mentor or guidance and wish to learn Machine learning. Using our repo they can learn ML, DL, and many related technologies with different real-world projects and become Interview ready.
MIT License
334 stars 296 forks source link

Web scraping bs4 #723

Closed speckofstardust closed 2 weeks ago

speckofstardust commented 1 month ago

resolved #592 by:

  1. Removing multiple .ipynb files with invalid JSON.
  2. Demonstrated web scraping on i) https://realpython.github.io/fake-jobs/ site which is an example site with fake job postings that you can freely scrape to train your skills and ii)amazon product review

The idea of scraping a Wikipedia page as mentioned in the issue was not pursued due to unclear terms and conditions regarding its legality.

Niketkumardheeryan commented 1 month ago

hi @speckofstardust , good work but try to improve your coding style, you are just using 2 or 3 cells to write your whole code , try to add more cell or comments in your code .

speckofstardust commented 3 weeks ago

hello @Niketkumardheeryan ! Thank you for reviewing and suggesting improvements in my coding style. I've made the suggested changes now. I also had to use a different product to scrap reviews from in the amazon product review due to accidentally triggering CAPTCHA in the old one. These are the changes I've made this time. Please let me know if there is anything else.

Niketkumardheeryan commented 3 weeks ago

@speckofstardust please wrap your output as it's creating confusion, please add proper comments, Improve your readme.md file as well

speckofstardust commented 2 weeks ago

hi @Niketkumardheeryan I've updated the readme.md file add added appropriate comments now. Not sure what you mean by wrapping output though? Could you please elaborate on that? If it's the length of some of the outputs that's causing confusion, i can try putting them in a .txt or .md file for reference. Is that what you meant?