Open arunitasahu opened 3 weeks ago
@invigorzz313 @Niketkumardheeryan Please review my pr and in case of no problems merge it with suitable label please.
@arunitasahu The description you wrote in the ReadMe.md file, its better if you include it in the .ipynb itself. Then the notebook would be interactive with proper code and text cells. Because we expect the code to be properly commented with explanations. As for the ReadMe.md, you can describe the techstack used, libraries used and aim & objective. Also include sample examples in it (original and final image pairs).
@invigorzz313 I have made the required changes .Please have a look into it.
@arunitasahu No cell Executed in your .ipynb file, please make it better readable with more commenting , also show used images in code ,
To illustrate how the code works and what the output looks like, I have added sample images. These images show both the functioning of the code and the appearance of the output.
@Niketkumardheeryan @invigorzz313
@arunitasahu It is suggested that you display the input and output images in the code too. For this you can use matplotlib library to display the figures. That way, the images are always visible instead of using cv2.waitkey for temporary viewing. And put in more comments example the "preprocessing and finding document contours" part, you can explain the major important commands being used.
closes : #766 The document scanning process involves several key steps: