search

Nikey646 / VndbSharp

A C# Vndb API Library. #OriginalNamingScheme
MIT License
18 stars 4 forks source link

changed IRequestOptions to lower case, so that they would work with the API #19

Closed micah686 closed 7 years ago

micah686 commented 7 years ago

Currently, if you attempt to use properties with standard naming conventions( like bool Property { get; set; }), the API will disregard the request, and it will not work.

I contacted Vndb's admin about this, and he confirmed that only lowercase works.

Nikey646 commented 7 years ago

I would prefer that [JsonProperty(...)] would be used here, since the current naming conforms to PascalCase, which is what the rest of the library uses, along with what i believe is the C# Standard.

I had not considered this scenario though. Maybe a naming strategy should be used instead so that it's done automatically within the VndbContractResolver, and would likely work better in the long run, meaning that [JsonProperty(...)]s that are just to convert to/from snake_case could be removed instead.

If you want to close this PR, and create a new one using the Snake Naming Strategy. I'm not sure how Naming Strategies are used since i've never required them before (Just threw a [JsonProperty(...)] on whatever needed to be renamed) so make sure that it works as intended.