search

Nikey646 / VndbSharp

A C# Vndb API Library. #OriginalNamingScheme
MIT License
18 stars 4 forks source link

Deploy #68

Closed micah686 closed 3 years ago

micah686 commented 4 years ago

Created 2 github action scripts. CI is the current integration that runs for every push or pull request Release is the script that creates the Release builds and nuget packages Release ONLY triggers on a tag push/create. When a tag triggers the Release.yml, it will create a release with the zipped source, and the compiled files, as well as pushing the new release to nuget.org automatically

micah686 commented 4 years ago

Ok, I updated the workflow. it's seperated into 2 jobs, build and deploy. The 'build' job is required in order for deploy to run. On the deploy job, it will tell you if a release package will be created or not. All of the deploy steps require a tag to be created.

Nikey646 commented 4 years ago

Figured out why the cache step was causing the build to fail.

Because the project.assets.json file isn't stored with the cache, when the cache is restored the file just doesn't exist. This is required, along side the packages.lock.json file from Nuget to complete the dependency graph.

https://github.com/actions/cache/issues/427

We can either implement the solution I found there or wait for a response from the developers of actions/cache.

micah686 commented 4 years ago

I updated the code to use the cache files, and skip restore if the cache is found

micah686 commented 3 years ago

Is there anything else that needs to be changed on this deploy logic?

Nikey646 commented 3 years ago

Is there anything else that needs to be changed on this deploy logic?

Not sure, don't have time atm due to work to give it a look through, will review when I have time.

micah686 commented 3 years ago

@Nikey646, Could you take a look at this deploy script again? For the current merge conflict, it needs to keep this, since we are using the pacakges.lock.json to keep track of the nuget updates.

<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
Nikey646 commented 3 years ago

Both this PR and the one that reverts the changes are failing to build. I'll leave the changes reverted for the moment until I have a chance to debug it.