search

Nikey646 / VndbSharp

A C# Vndb API Library. #OriginalNamingScheme
MIT License
18 stars 4 forks source link

Add auto build and deployment github actions. #74

Closed micah686 closed 3 years ago

micah686 commented 3 years ago

Added a build action to automatically build the project on a push to master and deploy to nuget.org when a build is tagged.

Refer to #68 for the previous conversation on this PR.

@Nikey646 , this PR should be ready for a merge. I think the previous PR failed because it was targeting 4.6 while on a linux system. Per one of our previous conversations, I changed the csproj to target .net standard 1.3 and 2.1, covering from .NET Framework 4.6 up through >NET Core 3.0.

Nikey646 commented 3 years ago

Failed again.

Nikey646 commented 3 years ago

Will leave as-is and fix myself at a later date.

micah686 commented 3 years ago

Ok, I'll let you deal with the changes at a later date. Looking at the error, it looks like it might be with the packages.lock.json file, since I'm not sure if the project is building one currently. You may need to add this line to the csproj file:

<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>