search

Nikhil636 / Attendance-app

MIT License
5 stars 14 forks source link

Sign up screen for creating new accounts #8

Closed Nikhil636 closed 1 year ago

sagnik-sanyal commented 1 year ago

I want to work on this issue under JWOC. I can work on designing of the signup screen where the user will be able to create new accounts with state management using riverpod or provider although provider will be easier to understand for other people who are beginners and those who are working, whereas riverpod offers much more functionality than the traditional provider package.

Nikhil636 commented 1 year ago

You can start the work and do share your email so that I can give you access to firebase project.

sagnik-sanyal commented 1 year ago

@Nikhil636 My email sagniksanyal1502@gmail.com

sagnik-sanyal commented 1 year ago

@Nikhil636 Also do you have any reference ui for signup screen or do i have to design it from scratch on figma ?

Nikhil636 commented 1 year ago

@Nikhil636 Also do you have any reference ui for signup screen or do i have to design it from scratch on figma ?

There is no figma file. You have to design it from scratch , you can take reference from the login screen UI.

sagnik-sanyal commented 1 year ago

@Nikhil636 https://www.figma.com/file/wu0m9lsvN75WRnZPxKFiSo/Attendance-app?node-id=0%3A1&t=xgbpkFDKFllpVoa1-1 can you have a look at this whether you like this design or not. Also it would be great if you could lemme know what all parameters do you need from the user while signup

Nikhil636 commented 1 year ago

Yeah its good , you can also use labels instead of field title And sign-up screen should have UserId, full name, Email, password, confirm password . Each textform field should contain validators . And these data will get stored in the database except password. And will be use for login

sagnik-sanyal commented 1 year ago

hey @Nikhil636 can you please elaborate regarding the user id part , how the person will create their userid it is automatically generated during signup with firebase. Firebase signup is working fine as of now but the user id part is not clear to me

Nikhil636 commented 1 year ago

hey @Nikhil636 can you please elaborate regarding the user id part , how the person will create their userid it is automatically generated during signup with firebase. Firebase signup is working fine as of now but the user id part is not clear to me

just leave that userid part,

sagnik-sanyal commented 1 year ago

hey @Nikhil636 can you please elaborate regarding the user id part , how the person will create their userid it is automatically generated during signup with firebase. Firebase signup is working fine as of now but the user id part is not clear to me

just leave that userid part,

Pls can you try to check the PR , if it's okay you can merge it so that i can work on further part of the application

Nikhil636 commented 1 year ago

Can you please send the pr again I forgot to add labels

On Fri, Feb 17, 2023 at 12:59 AM SAGNIK SANYAL @.***> wrote:

hey @Nikhil636 https://github.com/Nikhil636 can you please elaborate regarding the user id part , how the person will create their userid it is automatically generated during signup with firebase. Firebase signup is working fine as of now but the user id part is not clear to me

just leave that userid part,

Pls can you try to check the PR

— Reply to this email directly, view it on GitHub https://github.com/Nikhil636/Attendance-app/issues/8#issuecomment-1433604354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW2OXZ4JW5XTEJ5IZHHXGD3WXZ5YJANCNFSM6AAAAAAU3PWJOI . You are receiving this because you were mentioned.Message ID: @.***>

sagnik-sanyal commented 1 year ago

Oh ok

sagnik-sanyal commented 1 year ago

@Nikhil636 but the thing is my branch will be outdated from my end and it might cause conflicts as you have already merged some PRs. What to do now ?

Nikhil636 commented 1 year ago

I have added the labels on your pr so there's no problem.

On Fri, Feb 17, 2023, 1:25 AM SAGNIK SANYAL @.***> wrote:

@Nikhil636 https://github.com/Nikhil636 but the thing is my branch will be outdated from my end and it might cause conflicts as you have already merged some PRs. What to do now ?

— Reply to this email directly, view it on GitHub https://github.com/Nikhil636/Attendance-app/issues/8#issuecomment-1433631424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW2OXZ7SNCBZONDGVARDR4DWX2A2DANCNFSM6AAAAAAU3PWJOI . You are receiving this because you were mentioned.Message ID: @.***>

sagnik-sanyal commented 1 year ago

Ok i have resent the new pr but if you have alredy merged the code i am unable to find the updated code with riverpod signup flow in your repository main branch @Nikhil636